python312Packages.pyhanko: fix on darwin (NixOS#367756)

khaneliman · Dec 23, 2024 · c8adff5 · c8adff5
2 parents 005dabd + 6815b62
commit c8adff5
Showing 1 changed file with 45 additions and 30 deletions.
diff --git a/pkgs/development/python-modules/pyhanko/default.nix b/pkgs/development/python-modules/pyhanko/default.nix
@@ -45,7 +45,7 @@ buildPythonPackage rec {
   src = fetchFromGitHub {
     owner = "MatthiasValvekens";
     repo = "pyHanko";
-    rev = "refs/tags/v${version}";
+    tag = "v${version}";
     hash = "sha256-HJkCQ5YDVr17gtY4PW89ep7GwFdP21/ruBEKm7j3+Qo=";
   };
 
@@ -92,36 +92,51 @@ buildPythonPackage rec {
     requests-mock
   ] ++ lib.flatten (lib.attrValues optional-dependencies);
 
-  disabledTestPaths = [
-    # ModuleNotFoundError: No module named 'csc_dummy'
-    "pyhanko_tests/test_csc.py"
-  ];
+  disabledTestPaths =
+    [
+      # ModuleNotFoundError: No module named 'csc_dummy'
+      "pyhanko_tests/test_csc.py"
+    ]
+    ++ lib.optionals stdenv.hostPlatform.isDarwin [
+      # OSError: One or more parameters passed to a function were not valid.
+      "pyhanko_tests/cli_tests"
+    ];
 
-  disabledTests = [
-    # Most of the test require working with local certificates,
-    # contacting OSCP or performing requests
-    "test_generic_data_sign_legacy"
-    "test_generic_data_sign"
-    "test_cms_v3_sign"
-    "test_detached_cms_with_self_reported_timestamp"
-    "test_detached_cms_with_tst"
-    "test_detached_cms_with_content_tst"
-    "test_detached_cms_with_wrong_content_tst"
-    "test_detached_with_malformed_content_tst"
-    "test_noop_attribute_prov"
-    "test_detached_cades_cms_with_tst"
-    "test_read_qr_config"
-    "test_no_changes_policy"
-    "test_bogus_metadata_manipulation"
-    "test_tamper_sig_obj"
-    "test_signed_file_diff_proxied_objs"
-    "test_pades_revinfo_live"
-    "test_diff_fallback_ok"
-    "test_no_diff_summary"
-    "test_ocsp_embed"
-    "test_ts_fetch_aiohttp"
-    "test_ts_fetch_requests"
-  ];
+  disabledTests =
+    [
+      # Most of the test require working with local certificates,
+      # contacting OSCP or performing requests
+      "test_generic_data_sign_legacy"
+      "test_generic_data_sign"
+      "test_cms_v3_sign"
+      "test_detached_cms_with_self_reported_timestamp"
+      "test_detached_cms_with_tst"
+      "test_detached_cms_with_content_tst"
+      "test_detached_cms_with_wrong_content_tst"
+      "test_detached_with_malformed_content_tst"
+      "test_noop_attribute_prov"
+      "test_detached_cades_cms_with_tst"
+      "test_read_qr_config"
+      "test_no_changes_policy"
+      "test_bogus_metadata_manipulation"
+      "test_tamper_sig_obj"
+      "test_signed_file_diff_proxied_objs"
+      "test_pades_revinfo_live"
+      "test_diff_fallback_ok"
+      "test_no_diff_summary"
+      "test_ocsp_embed"
+      "test_ts_fetch_aiohttp"
+      "test_ts_fetch_requests"
+    ]
+    ++ lib.optionals stdenv.hostPlatform.isDarwin [
+      # OSError: One or more parameters passed to a function were not valid.
+      "test_detached_cms_with_duplicated_attr"
+      "test_detached_cms_with_wrong_tst"
+      "test_diff_analysis_add_extensions_dict"
+      "test_diff_analysis_update_indirect_extensions_not_all_path"
+      "test_no_certificates"
+      "test_ocsp_without_nextupdate_embed"
+    ];
 
   pythonImportsCheck = [ "pyhanko" ];