Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from NixOS:master #49

Merged
merged 240 commits into from
Oct 20, 2023
Merged

[pull] master from NixOS:master #49

merged 240 commits into from
Oct 20, 2023

Conversation

pull[bot]
Copy link

@pull pull bot commented Oct 20, 2023

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

ShamrockLee and others added 30 commits July 22, 2023 15:38
Show the progress bar and other information during the download.
Provide a way to distinguish connection interrupt from authentication failure.
Include a kustomize_4 build, since v5 introduced breaking changes (kubernetes-sigs/kustomize#5128)
From systemd 243 release note[1]:

This release enables unprivileged programs (i.e. requiring neither
setuid nor file capabilities) to send ICMP Echo (i.e. ping) requests
by turning on the "net.ipv4.ping_group_range" sysctl of the Linux
kernel for the whole UNIX group range, i.e. all processes.

So this wrapper is not needed any more.

See also [2] and [3].

This patch also removes:
- apparmor profiles in NixOS for ping itself and the wrapped one
- other references for the wrapped ping

[1]: https://github.com/systemd/systemd/blob/8e2d9d40b33bc8e8f5d3479fb075d3fab32a4184/NEWS#L6457-L6464
[2]: systemd/systemd#13141
[3]: https://fedoraproject.org/wiki/Changes/EnableSysctlPingGroupRange
This reduces `runc` output closure size, particularly when not part of a
NixOS configuration.

`procps` was added in 50e24b8, with the commit message indicating
the purpose of adding `systemctl` and `busctl`, both of which are
provided by `systemd` and not `procps`.

Presumably `procps` was added to make `runc ps` work regardless of the
environment, but this incurs a significant cost in terms of closure size,
especially when `runc` is packaged into something other than a NixOS
system, such as a dev shell or a package that does not use `runc ps`.

The alternative for improving the closure size would be to trim `procps`
itself. Currently it has a `systemd` dependency that's a significant cost.
However, removing that would also change `ps` and therefore `runc ps`
behavior. Furthermore, it would put two `procps` variants into the closure
of NixOS systems, when installed there.

Considering the above and the fact that the best `ps` is already present on
NixOS and most systems, I consider it the best solution not to bundle it
with `runc`, and take it from the environment instead.
Signed-off-by: Christina Sørensen <[email protected]>
AndersonTorres and others added 28 commits October 20, 2023 00:53
fish: use the subcommand style for the status command
python310Packages.universal-pathlib: 0.1.3 -> 0.1.4
…s.logilab-common

python311Packages.logilab-common: 1.10.0 -> 1.11.0
aws-iam-authenticator: 0.6.11 -> 0.6.12
…s.rtree

python311Packages.rtree: 1.0.1 -> 1.1.0
xrootd: wrap executables with [DY]LD_LIBRARY_PATH prefix
…s.annotated-types

python310Packages.annotated-types: 0.5.0 -> 0.6.0
Co-authored-by: lucasew <[email protected]>
Co-authored-by: Artturi <[email protected]>
@pull pull bot added the ⤵️ pull label Oct 20, 2023
@pull pull bot merged commit 680602e into khaneliman:master Oct 20, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.