Skip to content

Commit

Permalink
[8.x] Add @kbn/shared-ux-router to shared bundle (elastic#204786) (e…
Browse files Browse the repository at this point in the history
…lastic#205278)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Add `@kbn/shared-ux-router` to shared bundle
(elastic#204786)](elastic#204786)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Anton
Dosov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-30T12:44:44Z","message":"Add
`@kbn/shared-ux-router` to shared bundle (elastic#204786)\n\n##
Summary\r\n\r\nPart of elastic#204761 .
This package\r\nis used by every app and I thought it is worth adding it
to the shared\r\nbundle. Especially since it is already part of
Bazel.","sha":"b64ff102045585b2f28ced7a612edcafd0944b6e","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor"],"number":204786,"url":"https://github.com/elastic/kibana/pull/204786","mergeCommit":{"message":"Add
`@kbn/shared-ux-router` to shared bundle (elastic#204786)\n\n##
Summary\r\n\r\nPart of elastic#204761 .
This package\r\nis used by every app and I thought it is worth adding it
to the shared\r\nbundle. Especially since it is already part of
Bazel.","sha":"b64ff102045585b2f28ced7a612edcafd0944b6e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204786","number":204786,"mergeCommit":{"message":"Add
`@kbn/shared-ux-router` to shared bundle (elastic#204786)\n\n##
Summary\r\n\r\nPart of elastic#204761 .
This package\r\nis used by every app and I thought it is worth adding it
to the shared\r\nbundle. Especially since it is already part of
Bazel.","sha":"b64ff102045585b2f28ced7a612edcafd0944b6e"}}]}]
BACKPORT-->
  • Loading branch information
Dosant authored Dec 31, 2024
1 parent dc711e6 commit 13aed70
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions packages/kbn-ui-shared-deps-src/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ webpack_cli(
"//packages/react/kibana_context/root",
"//packages/react/kibana_context/render",
"//packages/react/kibana_context/theme",
"//packages/shared-ux/router/impl:shared-ux-router",
],
output_dir = True,
args = [
Expand Down
1 change: 1 addition & 0 deletions packages/kbn-ui-shared-deps-src/src/definitions.js
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ const externals = {
'@kbn/react-kibana-context-root': '__kbnSharedDeps__.KbnReactKibanaContextRoot',
'@kbn/react-kibana-context-render': '__kbnSharedDeps__.KbnReactKibanaContextRender',
'@kbn/react-kibana-context-theme': '__kbnSharedDeps__.KbnReactKibanaContextTheme',
'@kbn/shared-ux-router': '__kbnSharedDeps__.KbnSharedUxRouter',
};

module.exports = { distDir, jsFilename, cssDistFilename, externals };
1 change: 1 addition & 0 deletions packages/kbn-ui-shared-deps-src/src/entry.js
Original file line number Diff line number Diff line change
Expand Up @@ -82,3 +82,4 @@ export const KbnReactKibanaContextCommon = require('@kbn/react-kibana-context-co
export const KbnReactKibanaContextRoot = require('@kbn/react-kibana-context-root');
export const KbnReactKibanaContextRender = require('@kbn/react-kibana-context-render');
export const KbnReactKibanaContextTheme = require('@kbn/react-kibana-context-theme');
export const KbnSharedUxRouter = require('@kbn/shared-ux-router');

0 comments on commit 13aed70

Please sign in to comment.