fix the issue where digital rewards could select physical add ons, re…

…move duplicated add-ons call (#2010)
kickstarter · Apr 4, 2024 · 765eb7f · 765eb7f
1 parent 9753b41
commit 765eb7f
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/app/src/main/java/com/kickstarter/viewmodels/projectpage/AddOnsViewModel.kt b/app/src/main/java/com/kickstarter/viewmodels/projectpage/AddOnsViewModel.kt
@@ -83,7 +83,7 @@ class AddOnsViewModel(val environment: Environment) : ViewModel() {
                 viewModelScope.launch {
                     emitCurrentState()
                 }
-                getAddOns(noShippingRule = false)
+                getAddOns(noShippingRule = shippingSelectorIsGone)
             }.addToDisposable(disposables)
 
         val shippingRule = getSelectedShippingRule(defaultShippingRuleObservable, currentUserReward)
@@ -191,8 +191,6 @@ class AddOnsViewModel(val environment: Environment) : ViewModel() {
             emitCurrentState()
         }
 
-        if (shippingSelectorIsGone) getAddOns(noShippingRule = true)
-
         this.currentUserReward.onNext(reward)
     }
 
@@ -205,7 +203,7 @@ class AddOnsViewModel(val environment: Environment) : ViewModel() {
             emitCurrentState()
         }
 
-        getAddOns(noShippingRule = false)
+        getAddOns(noShippingRule = shippingSelectorIsGone)
     }
 
     fun onAddOnsAddedOrRemoved(currentAddOnsSelections: MutableMap<Reward, Int>) {