Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBL-2041: Clean up feature flag for refactor fix payment #2218

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

Arkariang
Copy link
Contributor

@Arkariang Arkariang commented Jan 30, 2025

📲 What

  • Clean up of feature flag

🤔 Why

  • Removing old code 😈
  • PledgeFragment/VM have not being used since October last year when ff was turned on.

👀 See

  • No user facing changes
    | | |

📋 QA

  • CrowdfundCheckoutFragment is the one presented when fixing a pledge.

Story 📖

MBL-2041

@Arkariang Arkariang requested review from leighdouglas, jlplks, tonyteate and ycheng-kickstarter and removed request for leighdouglas January 30, 2025 22:00
@Arkariang Arkariang self-assigned this Jan 30, 2025
@Arkariang Arkariang marked this pull request as ready for review January 30, 2025 22:01
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.10%. Comparing base (0ae04da) to head (cd1eddd).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2218      +/-   ##
============================================
- Coverage     68.21%   68.10%   -0.11%     
+ Complexity     2200     2190      -10     
============================================
  Files           354      354              
  Lines         23866    23865       -1     
  Branches       3501     3501              
============================================
- Hits          16279    16254      -25     
- Misses         5746     5773      +27     
+ Partials       1841     1838       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ycheng-kickstarter ycheng-kickstarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, end of an era 🫡

@Arkariang Arkariang merged commit 9263ca9 into master Feb 3, 2025
3 checks passed
@Arkariang Arkariang deleted the imartin/MBL-2041-clean-fix-payment-refactor branch February 3, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants