-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MBL-1896] Update status label copy for PLOT-enabled pledges #2222
Open
jovaniks
wants to merge
14
commits into
main
Choose a base branch
from
jluna/MBL-1896/plot-manage-pledge-summary-status-label
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[MBL-1896] Update status label copy for PLOT-enabled pledges #2222
jovaniks
wants to merge
14
commits into
main
from
jluna/MBL-1896/plot-manage-pledge-summary-status-label
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amy-at-kickstarter
approved these changes
Dec 16, 2024
ifosli
approved these changes
Dec 17, 2024
5 tasks
Base automatically changed from
jluna/MBL-1815/plot-plan-selector-selected-state
to
main
December 17, 2024 20:08
…atus-label # Conflicts: # Kickstarter-iOS/Features/PledgeOverTime/Controller/PledgePaymentPlansViewController.swift # Kickstarter-iOS/Features/PledgeOverTime/Controller/PledgePaymentPlansViewControllerTest.swift # Kickstarter-iOS/Features/PledgeOverTime/Views/PledgePaymentPlanOptionView.swift # Library/ViewModels/NoShippingPledgeViewModel.swift # Library/ViewModels/PledgePaymentPlansOptionViewModel.swift # Library/ViewModels/PledgePaymentPlansOptionViewModelTest.swift # Library/ViewModels/PledgePaymentPlansViewModel.swift # Library/ViewModels/PledgePaymentPlansViewModelTest.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
This PR updates the status label copy for PLOT-enabled pledges to display the correct payment information, such as the first charge amount and collection date, in the "Manage Pledge" screen.
🤔 Why
For backers using the Pledge Over Time (PLOT) payment plan, it is important to display clear and accurate details about the next payment. Updating the status label copy ensures backers know when the first charge will occur and the corresponding amount, aligning with the PLOT functionality.
🛠 How
backing.PaymentIncrements
API is not yet available (MBL-1851), a temporary validation has been added for development and testing purposes.featurePledgeOverTimeEnabled()
flag is used to simulate that a pledge is PLOT-enabled.mockPledgePaymentIncrement
) is used to represent the paymentIncrements list.paymentIncrements
provides the amount and scheduled payment date for the status label.statusLabelText
logic to display the dynamic copy:👀 See
Jira
✅ Acceptance criteria
featurePledgeOverTimeEnabled()
istrue
.mockPledgePaymentIncrement
) is used for amount and date for testing purposes.featurePledgeOverTimeEnabled = false
).⏰ TODO
mockPledgePaymentIncrement
) with realbacking.PaymentIncrements
once the API is available (MBL-1851).