Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove aopalliance dependency #478

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Remove aopalliance dependency #478

merged 1 commit into from
Jan 3, 2024

Conversation

DaGeRe
Copy link
Contributor

@DaGeRe DaGeRe commented Jan 3, 2024

Pull Request

Contribution

This pull request provides the following contribution to Kieker

  • Contribution 1 The aopalliance dependency, that is not required, is removed now

Code Quality Thresholds

  • It was necessary to raise any code quality thresholds
  • If yes, which had to be raised and why was it necessary?
    ..

@DaGeRe DaGeRe force-pushed the KIEKER-1962-remove-aopalliance branch from 6f59867 to 290947c Compare January 3, 2024 13:48
rju
rju approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@rju rju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it compiles, the dependency is not necessary.

@rju rju merged commit 0d07317 into main Jan 3, 2024
18 of 27 checks passed
@rju rju deleted the KIEKER-1962-remove-aopalliance branch January 3, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rju rju rju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaGeRe @rju