Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container property to ElkEdge #209

Merged
merged 3 commits into from
Feb 3, 2025
Merged

Conversation

tuckergordon
Copy link
Contributor

ELK#775 added a container property to edges:

Write a container property into each edge after layout. This gives the id of the node that was this edge's container, and helps the user interpret the route points in the right coord system.

Updating the ElkEdge type to reflect this and avoid type errors.

Note to reviewers: not sure if this type belongs in ElkEdge, or ElkExtendedEdge. Based on the upstream PR, I think this should be a non-optional property but happy to make changes!

[ELK#775](eclipse-elk/elk#775) added a `container` property to edges:

> Write a container property into each edge after layout. This gives the id of the node that was this edge's container, and helps the user interpret the route points in the right coord system.

Updating the `ElkEdge` type to reflect this and avoid type errors
@soerendomroes
Copy link
Member

Thank you for this PR. We are in the process of improving the container property. I am however currently ill and so do not feel alarmed if it takes a while.

@tuckergordon
Copy link
Contributor Author

Thank you, I appreciate that and all the work you've put into this library! I hope you feel better!

@wirekang
Copy link

wirekang commented May 21, 2024

container should be an optional type. As far as I understand, it is written during layout() process, so "input" edges don't need to have container property.

@skieffer
Copy link

skieffer commented Feb 2, 2025

it is written during layout() process, so "input" edges don't need to have container property.

That's correct. Furthermore, since eclipse-elk/elk#1071 (which supersedes the PR referenced above), the container property is written into edges only when CONTAINER coordinates mode is used. If ROOT or PARENT coordinates are used, then the property is not written at all, even after layout.

@skieffer
Copy link

skieffer commented Feb 2, 2025

I think the functioning of the container property is now settled enough that this could be merged.

@soerendomroes soerendomroes merged commit adcff05 into kieler:master Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants