seq2ffv1 - adds -framerate option #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @Yujing199603 - some DPX sequences have the incorrect FPS - which then gets passed along to the MKV file via rawcooked which results in bad framerates for the access copies.
This patch adds a
-framerateoption which will force a different framerate. I tested this with a DPX sequence that had an FPS of 24, but I used-framerate 16which resulted in the correct fps being used, and the losslessness verification was still LOSSLESS.This would appear to make the DPX header modification unnecessary. plz review @raecasey