Aws docs cleanup #580
Merged
Aws docs cleanup #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am just summarizing the pending work here:
I can merge this PR and the above can be addressed separately. What do you think @pierre, @sbrossie? cc @vnandwana. |
|
@reshmabidikar, I addressed the changes discussed on Slack. Since I do not have permission to push changes to this branch, I merged these changes to a branch in my repo and pushed additional changes. Changes are made to the following files: userguide/aws/how-to-maintain-a-cloud-formation-system.adoc userguide/aws/metrics-cloudwatch.adoc |
Update config parameters by updating a CF stack/screenshot of CloudWatch metrics
Deploying docs-killbill-io with
|
| Latest commit: |
517b94a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://212e47fd.docs-killbill-io.pages.dev |
| Branch Preview URL: | https://aws-docs-cleanup.docs-killbill-io.pages.dev |
sbrossie
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
All good to merge. @reshmabidikar @vnandwana Once merged, could you double check the doc we have generated looks good - it is sometimes hard from the adoc to feel 100% confident doc will render well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS docs cleanup. The work in this PR supersedes the work in #555. So once this PR is merged, #555 can be closed.
Currently in DRAFT status. Once @vnandwana addresses the issues discussed on Slack, we can merge.