Premium fixes #581
Closed
Premium fixes #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying docs-killbill-io with
|
| Latest commit: |
2730507
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2a48ae85.docs-killbill-io.pages.dev |
| Branch Preview URL: | https://premium-fixes.docs-killbill-io.pages.dev |
sbrossie
requested review from
reshmabidikar and
pierre
and removed request for
reshmabidikar
pierre
reviewed
Dec 7, 2024
There was a problem hiding this comment.
I would suggest to merge @reshmabidikar's PR first, I'm worried about AWS related conflicts.
FYI I'm not seeing the new Premium Capability page? 🤔
| @@ -2,7 +2,8 @@ nav.sidebar-nav | |||
| ul.nav.navbar-nav | |||
| li | |||
| .icon-title | |||
| a.bd-toc-link.main-link role="button" Getting Started | |||
There was a problem hiding this comment.
Verified that on preview pages there is no issue with the new spacing.
There was a problem hiding this comment.
Yep, from what I am seeing this works fine.
Forgot to push 😮💨 Fixed in 2730507 |
Yeah I had not realized there was draft PR with AWS changes... |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work on toc for make it more obvious that we have premium capabilities:
References)This is what this looks like: