Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address lodash security issue in lodash.pick #220

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Address lodash security issue in lodash.pick #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
89c2677
use full lodash library, update imports
bcgilliom Feb 13, 2024
fd246bb
fix imports
bcgilliom Feb 13, 2024
20b59da
remove built package
bcgilliom Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/react-native-version-check/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,7 @@
"url": "https://github.com/kimxogus/react-native-version-check/issues"
},
"dependencies": {
"lodash.isfunction": "^3.0.9",
"lodash.isnil": "^4.0.0",
"lodash.pick": "^4.4.0",
"lodash": "^4.17.21",
"semver": "^6.1.1"
},
"devDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native-version-check/src/getLatestVersion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// @flow
import { Platform } from 'react-native';
import isNil from 'lodash.isnil';
import isFunction from 'lodash.isfunction';
import isNil from 'lodash/isNil';
import isFunction from 'lodash/isFunction';

import * as providers from './providers';
import { IProvider, IVersionAndStoreUrl } from './providers/types';
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-version-check/src/getStoreUrl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// @flow
import { Platform } from 'react-native';
import isNil from 'lodash.isnil';
import isNil from 'lodash/isNil';
import { getVersionInfo } from './versionInfo';

export type GetAppStoreUrlOption = {
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-version-check/src/needUpdate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// @flow
import semver from 'semver';
import isNil from 'lodash.isnil';
import isNil from 'lodash/isNil';

import { getVersionInfo } from './versionInfo';
import * as providers from './providers';
Expand Down