Measurement buffer does not remove old observations if no observations are retrieved anymore #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… assure that new readings are included in the costmap within a single update cycle. Furthermore, fix `isCurrent` Logic to only report true if the costmap is really current (also after a reset).
… on when the last data was received)
|
Here the corresponding issue we raised in the official stvl repo: SteveMacenski#307 |
|
Closed because handled in a different PR on an individual branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the check in
RemoveStaleObservationssuch that it considers the age of the received data instead of when the data was received relative to the last received data.