fix: disable tls on elasticsearch connect #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,6 +22,9 @@ export const clean = async (moduleName: string, config: Config, moduleConfig: El | |||
| const client = new Client({ | |||
| auth: basicAuth, | |||
| nodes: nodes as string[], | |||
| tls: { | |||
| rejectUnauthorized: false, | |||
There was a problem hiding this comment.
@yian-shih do you think having this as parameter is a good idea?
There was a problem hiding this comment.
Hey Marek,
Yes, we can do that.
In the future, if any apps that need different configs then we can use parameter.
In that case, we would have better idea which config we need to enable as dynamic variables.
As all of our apps use the same config for Elasticsearch so I just keep this connection with minimum config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn off tls to fix the error
unable to verify the first certificate