Move DOM manipulation to the link function of the appropriate directive.

kineticsocial · Oct 7, 2015 · b34ecc3 · b34ecc3
1 parent 5ac3bdb
commit b34ecc3
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/angularjs-datetime-picker.js b/angularjs-datetime-picker.js
@@ -60,11 +60,6 @@
       datetimePickerEl = $compile(div)(options.scope)[0];
       datetimePickerEl.triggerEl = options.triggerEl;
 
-      // Hide the time selection if dateOnly is not set.
-      if (options.dateOnly === '' || options.dateOnly === true){
-        datetimePickerEl.querySelector('#adp-time').style.display = 'none';
-      }
-
       $document[0].body.appendChild(datetimePickerEl);
 
       //show datetimePicker below triggerEl
@@ -183,6 +178,10 @@
       scope.inputHour;
       scope.inputMinute;
 
+      if (scope.dateOnly === true){
+        element[0].querySelector('#adp-time').style.display = 'none';
+      }
+
       scope.$applyAsync( function() {
         ctrl.triggerEl = angular.element(element[0].triggerEl);
         if (attrs.ngModel) { // need to parse date string