Fix error when selectors empty

kirchbergerknorr · Aug 2, 2020 · d3bda5d · d3bda5d
1 parent badb0c4
commit d3bda5d
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/src/Helper/Config.php b/src/Helper/Config.php
@@ -70,7 +70,11 @@ public function getScriptUrl() :string
     public function getSelectors(): array
     {
         $selectors = [];
-        $selectorsRaw = $this->serializer->unserialize($this->getConfigValue('selectors'));
+        try {
+            $selectorsRaw = $this->serializer->unserialize($this->getConfigValue('selectors'));
+        } catch (\InvalidArgumentException $e) {
+            return $selectors;
+        }
 
         if (is_array($selectorsRaw)) {
             foreach ($selectorsRaw as $selectorRaw) {

diff --git a/src/Test/Unit/Helper/ConfigTest.php b/src/Test/Unit/Helper/ConfigTest.php
@@ -111,6 +111,21 @@ public function testGetSelectors()
         $this->assertNotEmpty($selectors);
     }
 
+    /**
+     * @return void
+     */
+    public function testGetSelectorsException()
+    {
+        $this->serializer->method('unserialize')->willThrowException(
+            new \InvalidArgumentException()
+        );
+
+        $selectors = $this->configHelper->getSelectors();
+
+        $this->assertEmpty($selectors);
+        $this->assertInternalType( 'array', $selectors);
+    }
+
     /**
      * @return array
      */