Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/add test coverage #1

Merged
merged 7 commits into from
Nov 7, 2024
Merged

Test/add test coverage #1

merged 7 commits into from
Nov 7, 2024

Conversation

kiritowu
Copy link
Owner

@kiritowu kiritowu commented Nov 7, 2024

Changes:

  • Add full test coverage to current code base.
  • Set max_retry default for tenacity.
  • Ensure asyncio_detailed are awaited for tenacity retry
  • Return last response if tenacity catches fails. This is to properly return TooManyRequestsError as expected.

@kiritowu kiritowu added the enhancement New feature or request label Nov 7, 2024
@kiritowu kiritowu self-assigned this Nov 7, 2024
Copy link

github-actions bot commented Nov 7, 2024

Coverage

Coverage Report
FileStmtsMissCover
nlb_catalogue_client
   client.py1170100%
   errors.py60100%
   types.py230100%
nlb_catalogue_client/api/catalogue
   get_get_availability_info.py700100%
   get_get_most_checkouts_trends_titles.py660100%
   get_get_new_titles.py890100%
   get_get_title_details.py660100%
   get_get_titles.py730100%
   get_search_titles.py930100%
nlb_catalogue_client/models
   bad_request_error.py260100%
   bib_format.py200100%
   book_cover.py540100%
   checkouts_title.py930100%
   checkouts_trend.py800100%
   course_code.py340100%
   facet.py700100%
   facet_data.py460100%
   get_availability_info_response_v2.py550100%
   get_title_details_response_v2.py8090100%
   get_titles_response_v2.py550100%
   internal_server_error.py260100%
   item.py1400100%
   location.py200100%
   media.py200100%
   method_not_allowed_error.py260100%
   new_arrival_title.py8090100%
   not_found_error.py260100%
   not_implemented_error.py260100%
   search_most_checkouts_titles_response.py300100%
   search_new_titles_response_v2.py500100%
   search_titles_response_v2.py650100%
   service_unavailable_error.py260100%
   status.py540100%
   title.py8090100%
   title_record.py7310100%
   title_summary.py1350100%
   too_many_requests_error.py260100%
   transaction_status.py540100%
   unauthorized_error.py260100%
   usage_level.py200100%
TOTAL50640100%

Tests Skipped Failures Errors Time
474 0 💤 0 ❌ 0 🔥 9.407s ⏱️

@kiritowu kiritowu merged commit 611125b into main Nov 7, 2024
4 checks passed
@kiritowu kiritowu deleted the test/add-test-coverage branch November 7, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant