Some Cleanups (#79)

* Enforce reloading of snapshots

* Enforce no optionals in parameters & Use u code for symbols

build.gradle

@@ -82,3 +82,7 @@ spotless {
         importOrderFile('spotless.importorder')
     }
 }
+
+configurations.configureEach {
+    resolutionStrategy.cacheChangingModulesFor 0, 'seconds'
+}

src/main/java/edu/kit/kastel/sdq/intelligrade/extensions/guis/ExercisePanel.java

@@ -3,7 +3,6 @@
 
 import java.awt.event.ItemEvent;
 import java.util.List;
-import java.util.Optional;
 import java.util.function.Predicate;
 
 import javax.swing.JButton;
@@ -283,25 +282,25 @@ private void handleCourseSelected(ItemEvent e) {
         }
     }
 
-    private void handleConnectionChange(Optional<ArtemisConnection> connection) {
+    private void handleConnectionChange(ArtemisConnection connection) {
         courseSelector.removeAllItems();
 
-        if (connection.isPresent()) {
+        if (connection != null) {
             // When a connection is established, update the course selector with the courses of the connection
             try {
-                connectedLabel.setText("✔ Connected to "
-                        + connection.get().getClient().getInstance().getDomain() + " as "
-                        + connection.get().getAssessor().getLogin());
+                connectedLabel.setText("\u2714 Connected to "
+                        + connection.getClient().getInstance().getDomain() + " as "
+                        + connection.getAssessor().getLogin());
                 connectedLabel.setForeground(JBColor.GREEN);
-                for (Course course : connection.get().getCourses()) {
+                for (Course course : connection.getCourses()) {
                     courseSelector.addItem(course);
                 }
             } catch (ArtemisNetworkException ex) {
                 LOG.warn(ex);
                 ArtemisUtils.displayNetworkErrorBalloon("Failed to fetch course info", ex);
             }
         } else {
-            connectedLabel.setText("❌ Not connected");
+            connectedLabel.setText("\u274C Not connected");
             connectedLabel.setForeground(JBColor.RED);
         }
 

src/main/java/edu/kit/kastel/sdq/intelligrade/state/PluginState.java

@@ -48,7 +48,7 @@ public class PluginState {
 
     private static PluginState pluginState;
 
-    private final List<Consumer<Optional<ArtemisConnection>>> connectedListeners = new ArrayList<>();
+    private final List<Consumer<ArtemisConnection>> connectedListeners = new ArrayList<>();
     private final List<Consumer<ActiveAssessment>> assessmentStartedListeners = new ArrayList<>();
     private final List<Runnable> assessmentClosedListeners = new ArrayList<>();
 
@@ -143,9 +143,9 @@ public void connect() {
                 });
     }
 
-    public void registerConnectedListener(Consumer<Optional<ArtemisConnection>> listener) {
+    public void registerConnectedListener(Consumer<ArtemisConnection> listener) {
         this.connectedListeners.add(listener);
-        listener.accept(Optional.ofNullable(this.connection));
+        listener.accept(this.connection);
     }
 
     public boolean isAssessing() {
@@ -318,8 +318,8 @@ private void verifyLogin() throws ArtemisClientException {
 
     private void notifyConnectedListeners() {
         ApplicationManager.getApplication().invokeLater(() -> {
-            for (Consumer<Optional<ArtemisConnection>> l : this.connectedListeners) {
-                l.accept(Optional.ofNullable(this.connection));
+            for (Consumer<ArtemisConnection> l : this.connectedListeners) {
+                l.accept(this.connection);
             }
         });
     }

src/test/java/edu/kit/kastel/ArchitectureTest.java

@@ -4,6 +4,7 @@
 import static com.tngtech.archunit.lang.syntax.ArchRuleDefinition.*;
 
 import java.util.List;
+import java.util.Optional;
 import java.util.function.Consumer;
 import java.util.stream.Stream;
 
@@ -24,4 +25,10 @@ class ArchitectureTest {
             .orShould()
             .callMethod(List.class, "forEachOrdered", Consumer.class)
             .because("Lambdas should be functional. ForEach is typically used for side-effects.");
+
+    @ArchTest
+    static final ArchRule noOptionalAsParameter = noMethods()
+            .should()
+            .haveRawParameterTypes(Optional.class)
+            .because("Optional should be used as return type only.");
 }