fix workflow creation on migration #3811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😵 💥 |
Kathrin-Huber
force-pushed
the
fix_workflow_migration
branch
from
4200b28 to
a6b7af6
Compare
Kathrin-Huber
force-pushed
the
fix_workflow_migration
branch
from
a6b7af6 to
3c6975d
Compare
|
|
solth
reviewed
Jul 8, 2020
| @@ -50,21 +51,22 @@ static String generateTask(Task task) { | |||
| * for sequence flow | |||
| * @return generated task | |||
| */ | |||
| static String generateTask(Task task, String sourceReference, String targetReference) { | |||
| static String generateTask(Task task, String sourceReference, String targetReference, int ordering) { | |||
There was a problem hiding this comment.
You could probably remove the third parameter targetReference - because it is always "Task_" + order - to simplify the method signature a little bit to
static String generateTask(Task task, String sourceReference, int ordering)
solth
approved these changes
Jul 8, 2020
Kathrin-Huber
force-pushed
the
fix_workflow_migration
branch
from
41081ef to
2a19f89
Compare
Kathrin-Huber
force-pushed
the
fix_workflow_migration
branch
from
2a19f89 to
8180773
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3759
resolves #3760
fix #3761
closes #3754
fixed #3758
close #3757
resolved #3755