Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow KitodoScript as action #4462

Merged

Conversation

matthias-ronge
Copy link
Collaborator

@matthias-ronge matthias-ronge commented Jun 8, 2021

As the title says: If you specify a KitodoScript as a script in the workflow editor, this is executed using the KitodoScriptService. The distinguishing is done by that a KitodoScript always begins with the character string "action:" (which happens to be a semantically valid indicator for a protocol, by the way). In combination with the functionality from pull request #4450, this provides for writing media files to the METS file in the course of the workflow without having to open the metadata editor and click on Save, which was a long-cherished wish.

The KitodoScriptService was adapted so that it is provided via the ServiceLoader like all other services, so that we have a uniform procedure here.

This feature is funded by Technische Universität Darmstadt.

@Kathrin-Huber
Copy link
Contributor

I don't get it to work. The script is not shown in the task (as link to click) and it is not triggered by automatic tasks.
How can I test it?

@matthias-ronge matthias-ronge marked this pull request as draft June 25, 2021 08:20
@matthias-ronge matthias-ronge marked this pull request as ready for review June 30, 2021 12:17
@matthias-ronge
Copy link
Collaborator Author

I tested it once again and I find it working when clicking on the link.

There is nothing special, just put the KitodoScript in the script box:

Configure script

@Kathrin-Huber Kathrin-Huber merged commit 6d59a9d into kitodo:master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants