Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import process design #4834

Merged
merged 4 commits into from
Dec 14, 2021

Conversation

IkramMaalej
Copy link
Collaborator

@IkramMaalej IkramMaalej commented Nov 24, 2021

Fixes #3529
Fixes #4777
Part of #4322

In this PR I have try to simplify the page design of creation of a new process from template by :

  • Combining the first Tab 'Basic data' and the second tab 'Metadata' in one tab.

Bildschirmfoto 2021-11-25 um 10 06 16

  • Convert 'process from template' tab to a dialog in order to make this way of importing data looks like the other ways 'Catalogue search' and 'File upload'.

Bildschirmfoto 2021-11-25 um 10 09 24

  • Grouping the buttons in the header into two menu buttons, one for "data transfer" and one for "saving" in order not to have a cluttered header space.

Bildschirmfoto 2021-11-25 um 10 08 32
Bildschirmfoto 2021-11-25 um 10 08 47

@IkramMaalej IkramMaalej changed the title Import wizard design Import process design Nov 25, 2021
Kitodo/src/main/webapp/pages/processFromTemplate.xhtml Outdated Show resolved Hide resolved
styleClass="secondary">
<p:resetInput target="fileUploadForm"/>
</p:commandButton>
<p:splitButton id="saveContinue"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to not combine both Save buttons into one split button but leave them as they are as two separate buttons that are always displayed, because they seem both equally relevant to me.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will look then like this

Bildschirmfoto 2021-11-25 um 13 33 45

@solth
Copy link
Member

solth commented Nov 30, 2021

Resolves #3529, doesn't it?

@IkramMaalej
Copy link
Collaborator Author

Resolves #3529, doesn't it?

Yes!

@Kathrin-Huber Kathrin-Huber merged commit e75b8c1 into kitodo:master Dec 14, 2021
@IkramMaalej IkramMaalej deleted the import-wizard-Design branch December 15, 2021 13:11
@solth
Copy link
Member

solth commented Dec 17, 2021

I believe this also fixed #4777.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants