Prevent NPE #5831
Merged
Prevent NPE #5831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not crash the building of error messages it an argument is
null.The message building checks the result string, if all
insertions have been inserted in the string. If not, they are appended. Example:“Metadata entry {0} not allowed for division {1}” ["TitleDocMain", "ephemera", "ruleset_default", "IOException: Cannot read ruleset_default.xml"] → “Metadata TitleDocMain not allowed for division ephemera: ruleset_default: IOException: Cannot read ruleset_default.xml”.
If an
insertionisnull, the testif (!messageBuilder.toString().contains(insertion))(next line) will throw aNullPointerException. Error message building shouldn’t throw an exception by itself.