Use efficient isEmpty call over inefficient empty string comparison #5944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solth
requested changes
Feb 26, 2024
Kitodo/src/main/java/org/kitodo/production/services/file/FileService.java
Outdated
Show resolved
Hide resolved
Kitodo/src/main/java/org/kitodo/production/services/file/FileService.java
Outdated
Show resolved
Hide resolved
Kitodo/src/main/java/org/kitodo/production/services/index/IndexingService.java
Outdated
Show resolved
Hide resolved
solth
approved these changes
Feb 26, 2024
henning-gerhardt
force-pushed
the
replace_equals_with_isEmpty
branch
from
25fb5fe to
5be965d
Compare
henning-gerhardt
force-pushed
the
replace_equals_with_isEmpty
branch
from
5be965d to
b598388
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isEmptycall is more efficient than a complexequalscall on strings if only comparison is on empty or not empty string.Discovered by CodeQL scan.