Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing hashCode methods #5946

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

henning-gerhardt
Copy link
Collaborator

@henning-gerhardt henning-gerhardt commented Feb 24, 2024

In this classes are equals() methods implemented without necessary hashCode() method. hashCode() methods are needed by HashMap or similar classes on usage. Objects.hashCode is available since Java 6 and can create unique results instead of self-implementing.

Discovered by CodeQL.

@henning-gerhardt henning-gerhardt force-pushed the add_missing_hashcode_methods branch from 24cd84a to 13430ba Compare February 28, 2024 14:24
@solth
Copy link
Member

solth commented Mar 4, 2024

@henning-gerhardt would you mind rebasing your branch one more time?

@henning-gerhardt henning-gerhardt force-pushed the add_missing_hashcode_methods branch from 13430ba to 571d493 Compare March 4, 2024 07:49
@solth solth merged commit 25d1d7f into kitodo:master Mar 4, 2024
5 checks passed
@henning-gerhardt henning-gerhardt deleted the add_missing_hashcode_methods branch March 4, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants