Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spotbugs on automatic build #5971

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

henning-gerhardt
Copy link
Collaborator

Current execution of spotbugs on automatic build is useless as

  • spotbugs messages got lost after build is done
  • spotbugs reports more and more issues which not get fixed in time and increasing the log output to an level where the log out is not visible more on GitHub
  • spotbugs is configured to only report issues but not break the build. Enabling this breaking on build even for a "high" threshold level would result first in fixing over 100 high level issues reported by spotbugs
  • CodeQL integration did at least do the same with a lot better integration into GitHub

Deactivating spotbugs will result in

  • (a little bit) faster automatic test execution
  • less log output messages

@solth solth merged commit 8e21c25 into kitodo:master Apr 9, 2024
5 checks passed
@henning-gerhardt henning-gerhardt deleted the deactivate_spotbugs branch April 9, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants