Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.6] Backport of - Allow multiple values for same key in mass import csv #6031

Merged
merged 10 commits into from
May 7, 2024

Conversation

BartChris
Copy link
Collaborator

Backport of #5998

@BartChris BartChris force-pushed the multi_value_mass_import_backport branch 2 times, most recently from 628aa45 to 434d1c7 Compare April 16, 2024 13:29
@BartChris
Copy link
Collaborator Author

BartChris commented Apr 16, 2024

I have no idea why the selenium tests for the Calendar are failing in the CI, locally they seem to work. I have not been able to fix them and as far as i can see nothing has changed in the calendar page..

Error:    CalendarST.createProcessFromCalendar Multiple Failures (2 failures)
	org.awaitility.core.ConditionTimeoutException: Condition with alias 'Wait for openCalendarLink to be clickable' didn't complete within 5 seconds because condition with lambda expression in org.kitodo.selenium.testframework.pages.ProcessesPage that uses org.openqa.selenium.WebElement was not fulfilled.
	org.openqa.selenium.NoSuchElementException: no such element: Unable to locate element: {"method":"css selector","selector":"#editForm\:cancel"}
  (Session info: chrome=123.0.6312.122)

@BartChris BartChris force-pushed the multi_value_mass_import_backport branch 7 times, most recently from 2c9428e to 3d9759d Compare April 30, 2024 12:49
@BartChris
Copy link
Collaborator Author

BartChris commented Apr 30, 2024

@solth @oliver-stoehr I still have problems getting the tests working. What is failing now is the
NewspaperProcessesGeneratorIT.shouldGenerateNewspaperProcesses test. Maybe this is caused by bringing in changes to the implementation of the Calendar Selenium test from #5949 into this PR to increase stability of those tests since they were failing before. I have no idea why the newspaper integration tests are failing. SInce you reworked a lot of tests maybe you have an idea what is going on here.

javax.naming.ConfigurationException: null
        at java.util.Optional.orElseThrow(Optional.java:408) ~[?:?]
        at org.kitodo.production.process.NewspaperProcessesGenerator.initializeRulesetFields(NewspaperProcessesGenerator.java:356) ~[classes/:?]
        at org.kitodo.production.process.NewspaperProcessesGenerator.initialize(NewspaperProcessesGenerator.java:323) ~[classes/:?]
        at org.kitodo.production.process.NewspaperProcessesGenerator.nextStep(NewspaperProcessesGenerator.java:294) ~[classes/:?]
        at org.kitodo.production.helper.tasks.GeneratesNewspaperProcessesThread.run(GeneratesNewspaperProcessesThread.java:79) ~[classes/:?]

@oliver-stoehr
Copy link
Collaborator

@BartChris I will look into it and get back to you!

@oliver-stoehr
Copy link
Collaborator

I tried to reproduce the error on my local machine, but was not able to trigger the exception reliably.
Since this error occurs in NewspaperProcessesGeneratorIT it should be independent of the calendar selenium tests.
However could not find the exact source of this error. It might be the result of another test not cleaning up properly/modifying the file …/10/meta.xml used in this test.

@BartChris BartChris force-pushed the multi_value_mass_import_backport branch 3 times, most recently from 284695f to ca78f07 Compare May 3, 2024 17:02
@BartChris BartChris force-pushed the multi_value_mass_import_backport branch from ca78f07 to 603946b Compare May 6, 2024 09:32
@BartChris BartChris marked this pull request as ready for review May 6, 2024 10:18
@BartChris
Copy link
Collaborator Author

BartChris commented May 6, 2024

The issue with the failing Newspaper generation tests stems from the new test introduced in the Import Service integration tests. This test alters the meta/10.xml file, hence I reset this file after the completion of all tests within this class. Although the alterations to the Calendar tests are not strictly imperative for this pull request, considering the two instances of failure in the Selenium tests in the CI, I believe it might be good to incorporate them as well.

@solth solth merged commit e8a02ae into kitodo:3.6.x May 7, 2024
2 checks passed
@BartChris BartChris deleted the multi_value_mass_import_backport branch May 13, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants