Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle exception during Kitodo Script execution #6083

Merged
merged 1 commit into from
May 23, 2024

Conversation

solth
Copy link
Member

@solth solth commented May 16, 2024

Fixes #5976

Also makes the "error-messages" list scrollable since it might contain many errors for many processes selected in the process list:

Bildschirmfoto 2024-05-16 um 15 01 38

(edit: may therefor have some relevance for #3392 as well)

Copy link
Collaborator

@BartChris BartChris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intended functionality is achieved: Adding data to a non-existing structural elements does no longer throw a Nullpointer exception. If multiple messages are displayed, the message is scrollable.
Code looks good. One might discuss wether it is necessary to catch the KitodoScriptExecutionException in case of calling deleteData, because as far as i can see, the exception will never be thrown in that case since no type is specified there. But maybe it is good to have the exception in place if this is changed in the future. (e.g. throwing an exception if a non existing metadata should be deleted)

@solth solth merged commit c3d5519 into kitodo:master May 23, 2024
5 checks passed
@solth solth deleted the kitodo-script-npe branch May 23, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhandled NullPointerException when using KitodoScript addDataToIssues
2 participants