-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove exif info from image uploads #352
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some small nits
this looks fine, I would keep it as something that is just forced on the users. I don't like the idea that an instance could accidentally let users post their geolocation. And yeah, it's not possible to do without buffering with current crates unfortunately. I wanna check for better alternatives but until then I would just add this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thanks!
Resolves #263
Supports jpeg, png and webp (just like img-parts)
Some things to still consider:
BytesMut
without any capacity, which means it has to reallocate when receiving new stream chunks. This is unfortunate but again, I don't think there's a way around that aspect too.