Remove the /oauth/token endpoint from the OpenAPI scheme #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand why clippy failed here lol |
|
You're still importing the module. Clippy runs on deny warnings |
|
Silly me, I did remove it that but forgot to push the commit, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now our schema is still invalid because of that
/oauth/tokenendpoint, as every endpoint in the OpenAPI spec needs to have at least one response defined, which we don't do right now. One way would would be to of course write all of these possible responses and their bodies etc. but there is actually no need to. OpenAPI docs state that including this endpoint is entirely optional so I propose just removing it from the schema. This endpoint is the same for every OAuth flow after all.