Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure search logic #397

Merged
merged 5 commits into from
Oct 29, 2023
Merged

Restructure search logic #397

merged 5 commits into from
Oct 29, 2023

Conversation

aumetra
Copy link
Member

@aumetra aumetra commented Oct 28, 2023

This PR restructures the search service in the following way:

  • kitsune_search is now considered a search backend abstraction
  • kitsune_core gets a new service: SearchService
    • This new service is only there to query the service and to do some resolving
    • It resolves posts and accounts by their URLs

The new structure should also enable some nicer query pipelining and will make it easier to keep the feature parity between the Mastodon and (eventual) GraphQL search on the same level.

@aumetra aumetra marked this pull request as ready for review October 29, 2023 13:17
@aumetra aumetra added this pull request to the merge queue Oct 29, 2023
Merged via the queue into main with commit 97eb0a2 Oct 29, 2023
10 checks passed
@aumetra aumetra deleted the aumetra/search-structure branch October 29, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aumetra