Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple federation protocols: Code restructure #421

Merged
merged 67 commits into from
Dec 3, 2023

Conversation

aumetra
Copy link
Member

@aumetra aumetra commented Nov 11, 2023

Restructure the code towards the support for multiple federation protocols

@aumetra aumetra mentioned this pull request Nov 11, 2023
@aumetra aumetra changed the title Code restructure Multiple federation protocols: Code restructure Nov 11, 2023
@aumetra
Copy link
Member Author

aumetra commented Nov 12, 2023

So the plan for kitsune-core is to literally rip most of the components out of it.
Services go into an own crate, resolvers go into own crates, job definitions go into the job runner crate, etc.

The core crate will pretty much only be there to define traits for the rest of the components, to provide generic interop.

@aumetra
Copy link
Member Author

aumetra commented Nov 12, 2023

The kitsune-activitypub crate shouldn't directly reference kitsune-webfinger, but instead something generic that satisfies the Resolver trait, but we aren't there yet where this trait is defined.

@aumetra aumetra force-pushed the aumetra/code-restructure branch from 27ebb84 to ff0bb2e Compare November 12, 2023 13:34
@aumetra aumetra force-pushed the aumetra/code-restructure branch from 4abe26c to 0233cd7 Compare November 12, 2023 15:37
@aumetra
Copy link
Member Author

aumetra commented Nov 13, 2023

Ugh.. now comes the awkward struggle where I have to somehow share parts of the services crate with the jobs crate in an attempt to use the mailing and user services inside the mailing job..

@aumetra aumetra force-pushed the aumetra/code-restructure branch from 042a72a to 8f93242 Compare December 3, 2023 15:40
@aumetra aumetra force-pushed the aumetra/code-restructure branch from 1e89bbc to d0da289 Compare December 3, 2023 18:25
@aumetra
Copy link
Member Author

aumetra commented Dec 3, 2023

I just wanna get this restructure out of my system. It took so much focus (and I suck at focussing at the moment), so I'll just merge when the tests pass, and then test and clean up later.

I don't think I wanna keep the main branch stale for much longer.

@aumetra aumetra marked this pull request as ready for review December 3, 2023 18:35
@aumetra aumetra enabled auto-merge December 3, 2023 18:35
@aumetra
Copy link
Member Author

aumetra commented Dec 3, 2023

Bloody hell.. not again the stack overflow assertion..
Is it because of the fat pointer needing two machine words instead of two? Is that section really that fragile?

@aumetra aumetra force-pushed the aumetra/code-restructure branch from 4112216 to b2bf32f Compare December 3, 2023 19:29
@aumetra aumetra added this pull request to the merge queue Dec 3, 2023
Merged via the queue into main with commit d275c80 Dec 3, 2023
22 checks passed
@aumetra aumetra deleted the aumetra/code-restructure branch December 3, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update uuid crate and remove uuid_unstable cfg flag
1 participant