Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend test coverage #505

Merged
merged 20 commits into from
Mar 21, 2024
Merged

Extend test coverage #505

merged 20 commits into from
Mar 21, 2024

Conversation

aumetra
Copy link
Member

@aumetra aumetra commented Mar 17, 2024

Extending the test coverage of the following sub-crates:

  • geomjeungja
  • masto-id-convert
  • speedy-uuid
  • tower-http-digest

Copy link

codecov bot commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 98.80952% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 31.39%. Comparing base (b023a12) to head (cd4ac5f).

❗ Current head cd4ac5f differs from pull request most recent head 9c0b5a2. Consider uploading reports for the commit 9c0b5a2 to get more accurate results

Files Patch % Lines
lib/speedy-uuid/src/lib.rs 98.18% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #505      +/-   ##
==========================================
+ Coverage   30.58%   31.39%   +0.81%     
==========================================
  Files         330      330              
  Lines       16517    16600      +83     
==========================================
+ Hits         5051     5212     +161     
+ Misses      11466    11388      -78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aumetra aumetra force-pushed the aumetra/test-coverage branch from 9443b0f to a2d964d Compare March 18, 2024 20:49
@aumetra aumetra marked this pull request as draft March 18, 2024 21:07
@aumetra
Copy link
Member Author

aumetra commented Mar 18, 2024

Last piece I want to test is the mrf-manifest crate and its parsing functionalities. Luckily that will be pretty easy using the wat crate and some manual WASM in text format.
Similar testing approach to what we use at CosmWasm.

After that we can merge this and focus on the restructure.

@aumetra aumetra force-pushed the aumetra/test-coverage branch from afe991f to a6e9e68 Compare March 21, 2024 22:54
@aumetra aumetra marked this pull request as ready for review March 21, 2024 23:09
@aumetra aumetra enabled auto-merge March 21, 2024 23:09
@aumetra aumetra added this pull request to the merge queue Mar 21, 2024
Merged via the queue into main with commit de7a7fd Mar 21, 2024
15 checks passed
@aumetra aumetra deleted the aumetra/test-coverage branch March 21, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant