-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and improve the nix flake #512
Conversation
4d980cc
to
35b5eda
Compare
Signed-off-by: Harald Hoyer <[email protected]>
Signed-off-by: Harald Hoyer <[email protected]>
Native deps need the tools which run on the build host (when cross compiling). Normal build deps are the libs linked to the binary. OPENSSL_NO_VENDOR ensures that openssl-sys uses the system lib. Remove the rest of the workarounds for openssl. Signed-off-by: Harald Hoyer <[email protected]>
Signed-off-by: Harald Hoyer <[email protected]>
6d625d1
to
9e69e96
Compare
Signed-off-by: Harald Hoyer <[email protected]>
Signed-off-by: Harald Hoyer <[email protected]>
Want me to disable |
Yeah, I think testing inside the nix build isn't really needed since we have our CI to ensure buildability. |
Done as a separate commit, so it is easy to revert. |
Thank you for introducing the crane library, I saw a bit about it but never really looked into it too much. |
https://crane.dev/ enables caching of artifacts and potentially reducing build time. Even End to End(E2E) testing could be added: https://crane.dev/examples/end-to-end-testing.html Signed-off-by: Harald Hoyer <[email protected]>
Signed-off-by: Harald Hoyer <[email protected]>
Left as a separate commit, so it is easy to revert. Signed-off-by: Harald Hoyer <[email protected]>
I had a misconfig in the crane calls, so it did not use the cached dependency build... Fixed that. Additionally the last commit changes the default to the |
Don't know why the build has failed.. no logs available. Maybe it ran out of RAM?? |
Just gonna rerun it, maybe it works now? If not, then I'll have a look. |
I had to change the nix build TMPDIR for my system, because it builds in |
Seems like a 2 debug builds in parallel is too big :) |
normal flake produces release code still. Signed-off-by: Harald Hoyer <[email protected]>
and skip running nixci. Signed-off-by: Harald Hoyer <[email protected]>
Signed-off-by: Harald Hoyer <[email protected]>
Thank you for working on this! This looks really good |
fix(flake):
public
assets were moved tokitsune/assets
feat(flake): use mold linker
fix(flake): fix build dependency for openssl
Native deps need the tools which run on the build host (when cross
compiling). Normal build deps are the libs linked to the binary.
OPENSSL_NO_VENDOR ensures that openssl-sys uses the system lib.
Remove the rest of the workarounds for openssl.
fix(flake): proper
mkYarnPackage
feat(flake): add overlay test
to test overlay.nix
fix(flake): skip more tests
feat(flake): use the crane nix lib
https://crane.dev/
enables caching of artifacts and potentially reducing build time.
Even End to End(E2E) testing could be added:
https://crane.dev/examples/end-to-end-testing.html
ci(flake): add nix github action