Update Meilisearch SDK #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version of the Meilisearch SDK released, this time with support for custom HTTP clients.
In this PR we implement a custom HTTP client based on
kitsune-http-clientand hook it up to the client SDK.That way we get rid of a bunch of dependencies that would otherwise be compiled into our binary, including OpenSSL.
This was also the main blocker why we didn't enable Meilisearch as a default feature. That means now we have it as a default feature, meaning all Kitsune instances should ship with Meilisearch support from now on.
Also, as a sidenote, the reason why
utoipa-swagger-uiis pinned to 6.0.0 is because they introduced a build time dependency onreqwestand I really don't want to add that to the dependency tree.I'm not entirely sure why they chose
reqwestout of all HTTP clients, especially for a build step.ureqwould have been totally sufficient (orminreq).Well, maybe gonna check that out and potentially open a PR later.