Panel positioning #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_positioning property to left, right, top or bottom.
…cceptable options.
|
This seems great, the only small problem is that when the panel isn't from the left the fade images used seem to be messed up (mispositioned a little and the wrong direction). Are you able to fix this? |
|
I'm having a problem with the reveal_below animations. They seem to position the joinimage in a way I don't understand. Currently the code positions the joinimage correctly for the other animations. I would appreciate your help :) |
…ositioning dimension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the property 'side_panel_positioning' that accepts either 'left', 'right', 'top', 'bottom' to position the edge of the window in which the side panel is pulled from.