Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for req-username-file and req-password-file cli flags #322

Merged
merged 5 commits into from
May 13, 2024
Merged

Adding support for req-username-file and req-password-file cli flags #322

merged 5 commits into from
May 13, 2024

Conversation

wasim-nihal
Copy link
Contributor

Changes for #318

@ChristianGeie
Copy link
Collaborator

ChristianGeie commented Feb 26, 2024 •
edited
Loading

@wasim-nihal thx for contributing.
lgtm so far.
Can you please provide a little test for this use case?

@wasim-nihal
Copy link
Contributor Author

Can you please provide a little test for this use case?

Sure, thanks for your review. I will add the test.

@wasim-nihal
Copy link
Contributor Author

Hi @ChristianGeie , I have added tests for the change. Can you please trigger the test execution and let me know if something needs to be updated.

@ChristianGeie
Copy link
Collaborator

@wasim-nihal i triggered the checks but after a couple of minutes i cancel because of observing an "endless" loop while sidecar-basicauth-args becomes ready. I haven't had the chance to look at it in detail yet.

@wasim-nihal
Copy link
Contributor Author

@ChristianGeie , I suspect the pod did not come up because the image name k8s-sidecar:testing was not found. I have corrected it in the latest commit with the right image kiwigrid/k8s-sidecar:testing . Could you please re-run it once?

@ChristianGeie
Copy link
Collaborator

Sure.

@ChristianGeie
Copy link
Collaborator

looks much better now

@wasim-nihal
Copy link
Contributor Author

Thanks @ChristianGeie

@wasim-nihal
Copy link
Contributor Author

@ChristianGeie, could you please let me know if any further changes are needed? I shall work on it.

@ChristianGeie ChristianGeie added enhancement New feature or request python Pull requests that update Python code labels May 13, 2024
@ChristianGeie
Copy link
Collaborator

@wasim-nihal i add k8s v1.29 in the meantime. So I start the tests again.

@wasim-nihal
Copy link
Contributor Author

sure

ChristianGeie
ChristianGeie approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@ChristianGeie ChristianGeie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ChristianGeie
Copy link
Collaborator

@wasim-nihal workflow for checks did not start, can you do a empty commit followed by a git push pls?

@wasim-nihal
Copy link
Contributor Author

@wasim-nihal workflow for checks did not start, can you do a empty commit followed by a git push pls?

Thanks, done rebsing. Workflows seem to have passed.

@ChristianGeie ChristianGeie merged commit de66738 into kiwigrid:master May 13, 2024
10 checks passed
@Fresa Fresa mentioned this pull request Aug 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianGeie ChristianGeie ChristianGeie approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wasim-nihal @ChristianGeie