Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to fetch only specific resources by name #383

Conversation

simonsystem
Copy link
Contributor

@simonsystem simonsystem commented Dec 19, 2024

This introduces a new environment variable RESOURCE_NAME which can be used, to configure specific resources being fetched by name.

RESOURCE_NAME can be a comma-separated list of resources, resource-type-prefixed resources or namespace-prefixed resources. E.g. resource-name,secret/resource-name,namespace/secret/resource-name

Closes #378

@ChristianGeie ChristianGeie added enhancement New feature or request python Pull requests that update Python code labels Dec 20, 2024
@ChristianGeie
Copy link
Collaborator

thx for contributing this awesome feature. it's also possible for you to implement testing the feature using sidecar-pythonscript-resource-name in github workflow?

@simonsystem
Copy link
Contributor Author

@ChristianGeie Added the github workflows. Tell me, if something is still missing.

@CarstenSon
Copy link

Hey @ChristianGeie :)

is something else needed for this PR to be accepted? Our team is also happily awaiting this feature and in case something is needed i'd love to help out with that!

@ChristianGeie
Copy link
Collaborator

Hi @CarstenSon , thx for your work.

I canceled the github workflow (see https://github.com/kiwigrid/k8s-sidecar/actions/runs/12430846663) after half an hour, so the test was not successful. Please take another look at this, it doesn't seem to be working properly yet.

If all tests are green, I can also merge your PR.

@simonsystem
Copy link
Contributor Author

@ChristianGeie @CarstenSon Fixed it! Workflow finnished successfully on my side. Would be nice, to see it merged. 🚀

Copy link
Collaborator

@ChristianGeie ChristianGeie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ChristianGeie ChristianGeie merged commit a0baed6 into kiwigrid:master Jan 10, 2025
8 checks passed
@simonsystem
Copy link
Contributor Author

Thank you everyone! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to limit serviceaccount to read only specified secrets/configmaps
3 participants