-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ability to fetch only specific resources by name #383
feat: add ability to fetch only specific resources by name #383
Conversation
thx for contributing this awesome feature. it's also possible for you to implement testing the feature using |
@ChristianGeie Added the github workflows. Tell me, if something is still missing. |
Hey @ChristianGeie :) is something else needed for this PR to be accepted? Our team is also happily awaiting this feature and in case something is needed i'd love to help out with that! |
Hi @CarstenSon , thx for your work. I canceled the github workflow (see https://github.com/kiwigrid/k8s-sidecar/actions/runs/12430846663) after half an hour, so the test was not successful. Please take another look at this, it doesn't seem to be working properly yet. If all tests are green, I can also merge your PR. |
@ChristianGeie @CarstenSon Fixed it! Workflow finnished successfully on my side. Would be nice, to see it merged. 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thank you everyone! 😃 |
This introduces a new environment variable
RESOURCE_NAME
which can be used, to configure specific resources being fetched by name.RESOURCE_NAME
can be a comma-separated list of resources, resource-type-prefixed resources or namespace-prefixed resources. E.g.resource-name,secret/resource-name,namespace/secret/resource-name
Closes #378