Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store usernames in lowercase #119

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ItsOnlyBinary
Copy link
Contributor

Hopefully i got all the places that are needed.

also unsure if i should remove the 'LIKE' from the where clauses as i think its now redundant

@prawnsalad
Copy link
Member

Adding it here as it sets the username value will cover cases where a user is created via the model factory

set username(newVal) { return this.setData('username', newVal); }

@prawnsalad
Copy link
Member

As mentioned in #kiwiirc:

  • Include a data integrity function that runs on startup that checks for any usernames containing uppercase letters (where lower(username) != username)
  • If any are found, throw out an error explaining the issue and what to do before exiting.
  • Include a config option skip_data_integrity_check, true/false. Defaults to false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants