Fixed the app crashes that occurred when deleting letters in a search. #3592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 11, 2023 18:04
* Removed the unnecessary estimation matches call on `libkiwix`, as we do not need this since `libkiwix` can handle this automatically. * Cancelled the previously running job if a new searchTerm is in progress; this will avoid unnecessary memory allocation and data load on libkiwix.
…arch loading functionality.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #3592 +/- ##
=============================================
+ Coverage 48.94% 48.98% +0.03%
- Complexity 1088 1092 +4
=============================================
Files 285 285
Lines 10495 10502 +7
Branches 1404 1406 +2
=============================================
+ Hits 5137 5144 +7
+ Misses 4528 4527 -1
- Partials 830 831 +1 ☔ View full report in Codecov by Sentry. |
… This enables proper clearing of the first running job before executing a new one. By implementing this approach, we ensure that access to the libzim search results occurs one at a time, resolving the crashing issue caused by multiple attempts to access libzim resources. * Replaced the `cancel` function for the Job with `cancelAndJoin`, ensuring that it thoroughly cancels the first job before initiating the new task.
|
@gouri-panda This PR is ready for review. |
gouri-panda
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3581
libkiwix, as we do not need this sincelibkiwixcan handle this automatically.searchTermis in progress; this will avoid unnecessary memory allocation and data load on libkiwix.