Refactor GitHub Action for Emulator Runner Job Redundancy #3616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3616 +/- ##
============================================
- Coverage 48.95% 48.74% -0.22%
Complexity 1090 1090
============================================
Files 285 285
Lines 10556 10556
Branches 1413 1413
============================================
- Hits 5168 5145 -23
- Misses 4553 4571 +18
- Partials 835 840 +5 ☔ View full report in Codecov by Sentry. |
MohitMaliFtechiz
requested changes
Dec 18, 2023
There was a problem hiding this comment.
@gouri-panda Thanks for the PR, just need a small change, and then we are good to merge.
MohitMaliFtechiz
previously approved these changes
Dec 18, 2023
kelson42
requested changes
Dec 19, 2023
MohitMaliFtechiz
force-pushed
the
Fixes-#3615
branch
from
6532d06 to
6f7560f
Compare
kelson42
force-pushed
the
Fixes-#3615
branch
from
6f7560f to
394e72b
Compare
|
@kelson42 Thanks! |
MohitMaliFtechiz
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3615
Description
This pull request addresses the redundancy in the GitHub Actions workflow for creating instrumentation coverage with the Android Emulator Runner. The current workflow contains duplicated code, and this PR refactors it into a single job definition with conditional parameter assignments based on the value of matrix.api-level.