Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: The chooser UI now defaults to displaying external storage. #3619

Closed
wants to merge 1 commit into from

Conversation

MohitMaliFtechiz
Copy link
Collaborator

Fixes #3604

  • Previously, it displayed the last known location when selecting a folder for external storage, which could confuse the user. We have now resolved this by defaulting to opening the SD card when choosing the SD card folder.

* Previously, it displayed the last known location when selecting a folder for external storage, which could confuse the user. We have now resolved this by defaulting to opening the SD card when choosing the SD card folder.
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (bdbfe2f) 48.77% compared to head (50eeddd) 48.71%.
Report is 1 commits behind head on main.

Files Patch % Lines
...rg/kiwix/kiwixmobile/core/utils/files/FileUtils.kt 0.00% 9 Missing ⚠️
...e/nav/destination/library/OnlineLibraryFragment.kt 0.00% 7 Missing ⚠️
...wix/kiwixmobile/core/settings/CorePrefsFragment.kt 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3619      +/-   ##
============================================
- Coverage     48.77%   48.71%   -0.07%     
+ Complexity     1093     1092       -1     
============================================
  Files           285      285              
  Lines         10567    10583      +16     
  Branches       1413     1420       +7     
============================================
+ Hits           5154     5155       +1     
- Misses         4573     4588      +15     
  Partials        840      840              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42
Copy link
Collaborator

kelson42 commented Dec 21, 2023

I hardly see how opening always external storage (if configured as storage space for downloader) should be a good choice. Opening last known place is the right approach. @MohitMaliFtechiz Feel free to comment here if there is really a good reason, I don't get it.

@kelson42 kelson42 closed this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot see wikipedia_en_all_maxi_2023-11.zim file on Android 12
2 participants