Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Extracted the website link from the string file for the Play Store restriction dialog. #3626

Merged
merged 2 commits into from
Dec 29, 2023

Conversation

MohitMaliFtechiz
Copy link
Collaborator

Fixes #3625

  • Removed the link from zim_files_not_showing_description.
  • Modified the dialog for displaying the link in PlayStoreRestrictionPopup.
  • Refactored the rawTitleDescriptionMap() method in HelpFragment to accommodate both strings and arrays for showing links inside the HelpFragment.
Fix.mp4

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (fff9991) 48.69% compared to head (9455847) 48.66%.

❗ Current head 9455847 differs from pull request most recent head 9b14868. Consider uploading reports for the commit 9b14868 to get more accurate results

Files Patch % Lines
...kiwix/kiwixmobile/core/utils/dialog/KiwixDialog.kt 0.00% 10 Missing ⚠️
...va/org/kiwix/kiwixmobile/core/help/HelpFragment.kt 33.33% 2 Missing and 2 partials ⚠️
...va/org/kiwix/kiwixmobile/help/KiwixHelpFragment.kt 0.00% 3 Missing ⚠️
...le/nav/destination/library/LocalLibraryFragment.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3626      +/-   ##
============================================
- Coverage     48.69%   48.66%   -0.04%     
  Complexity     1090     1090              
============================================
  Files           285      285              
  Lines         10564    10573       +9     
  Branches       1415     1417       +2     
============================================
+ Hits           5144     5145       +1     
- Misses         4579     4586       +7     
- Partials        841      842       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gouri-panda
gouri-panda previously approved these changes Dec 21, 2023
Copy link
Collaborator

@gouri-panda gouri-panda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MohitMaliFtechiz We know these are some flaky tests but we should address this problem more seriously. Is there anything related to this bug that I don't know?

@MohitMaliFtechiz
Copy link
Collaborator Author

MohitMaliFtechiz commented Dec 22, 2023

@MohitMaliFtechiz We know these are some flaky tests but we should address this problem more seriously. Is there anything related to this bug that I don't know?

@gouri-panda Here, the HelpFragmentTest was failing after this change, i have placed a fix for it.

Apart from this,

Screenshot from 2023-12-22 12-00-32

Since locally it hardly fails (To be honest, I have not seen the failure in these test cases), but if these are failing on CI there is something we are missing, I will take a look at these two test cases.

Edited: I have created a ticket for this #3627

@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as ready for review December 22, 2023 06:38
MohitMaliFtechiz added 2 commits December 29, 2023 09:44
…tore restriction dialog.

* Removed the link from `zim_files_not_showing_description`.
* Modified the dialog for displaying the link in `PlayStoreRestrictionPopup`.
* Refactored the `rawTitleDescriptionMap`() method in `HelpFragment` to accommodate both strings and arrays for showing links inside the HelpFragment.
@kelson42 kelson42 merged commit 61c6f96 into main Dec 29, 2023
4 of 7 checks passed
@kelson42 kelson42 deleted the Issue#3625 branch December 29, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract website link from string file for play store restriction dialog.
3 participants