-
-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed: Extracted the website link from the string file for the Play Store restriction dialog. #3626
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3626 +/- ##
============================================
- Coverage 48.69% 48.66% -0.04%
Complexity 1090 1090
============================================
Files 285 285
Lines 10564 10573 +9
Branches 1415 1417 +2
============================================
+ Hits 5144 5145 +1
- Misses 4579 4586 +7
- Partials 841 842 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MohitMaliFtechiz We know these are some flaky tests but we should address this problem more seriously. Is there anything related to this bug that I don't know?
@gouri-panda Here, the HelpFragmentTest was failing after this change, i have placed a fix for it. Apart from this,
Since locally it hardly fails (To be honest, I have not seen the failure in these test cases), but if these are failing on CI there is something we are missing, I will take a look at these two test cases. Edited: I have created a ticket for this #3627 |
…tore restriction dialog. * Removed the link from `zim_files_not_showing_description`. * Modified the dialog for displaying the link in `PlayStoreRestrictionPopup`. * Refactored the `rawTitleDescriptionMap`() method in `HelpFragment` to accommodate both strings and arrays for showing links inside the HelpFragment.
Fixes #3625
zim_files_not_showing_description
.PlayStoreRestrictionPopup
.rawTitleDescriptionMap
() method inHelpFragment
to accommodate both strings and arrays for showing links inside the HelpFragment.Fix.mp4