Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvement in showing the directory path in README file. #4208

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

MohitMaliFtechiz
Copy link
Collaborator

@MohitMaliFtechiz MohitMaliFtechiz commented Feb 3, 2025

* Updated the playStore link in the README file. The previous link https://android.kiwix.org/ was not working and it is not the Play Store link.

  • Minor improvement in showing the directory path. See the image below; the second directory path does not look correct.

Screenshot from 2025-02-03 12-27-29

@MohitMaliFtechiz MohitMaliFtechiz added this to the 3.14.0 milestone Feb 3, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.33%. Comparing base (81b730e) to head (5b7a3af).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4208      +/-   ##
============================================
+ Coverage     57.09%   57.33%   +0.24%     
+ Complexity     1552     1545       -7     
============================================
  Files           313      313              
  Lines         13515    13515              
  Branches       1695     1695              
============================================
+ Hits           7716     7749      +33     
+ Misses         4621     4599      -22     
+ Partials       1178     1167      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42
Copy link
Collaborator

kelson42 commented Feb 5, 2025

@MohitMaliFtechiz I don't know what you do, but the link works fine!

@MohitMaliFtechiz MohitMaliFtechiz force-pushed the readme_playstore_link_not_working branch from c9298a3 to 5b7a3af Compare February 5, 2025 10:21
@MohitMaliFtechiz
Copy link
Collaborator Author

MohitMaliFtechiz commented Feb 5, 2025

@MohitMaliFtechiz I don't know what you do, but the link works fine!

Ahh Sorry!! It was my WIFI issue that blocked this URL. I switched to the mobile network and now it is working. Additionally, connecting back to WIFI resolves the problem.

But the second improvement is needed, I am reverting the URL change.

@MohitMaliFtechiz MohitMaliFtechiz changed the title Fixed: The play store link in README file is not working. Minor improvement in showing the directory path in README file. Feb 5, 2025
@kelson42 kelson42 merged commit 256896f into main Feb 5, 2025
30 of 31 checks passed
@kelson42 kelson42 deleted the readme_playstore_link_not_working branch February 5, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants