Keeping the downloading books always at the top. #4211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohitMaliFtechiz
force-pushed
the
Fixes#4206
branch
from
6e77feb to
34925c4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4211 +/- ##
============================================
+ Coverage 56.91% 57.03% +0.11%
- Complexity 1547 1550 +3
============================================
Files 313 313
Lines 13590 13600 +10
Branches 1703 1703
============================================
+ Hits 7735 7757 +22
+ Misses 4679 4666 -13
- Partials 1176 1177 +1 ☔ View full report in Codecov by Sentry. |
* Added a new "Downloading:" section in `OnlineFragment` to display currently downloading books at the top. * The language, and search filter will not affect this meaning if a user selects another language and searches any ZIM file via the search feature, the "Downloading:" section always shows on the top and the filter will be applied to the remaining books.
MohitMaliFtechiz
force-pushed
the
Fixes#4206
branch
from
95d87f4 to
a3341fc
Compare
|
@MohitMaliDeveloper Screencast looks perfect to me! Thx! |
|
@kelson42 The PR is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4206
OnlineFragmentto display currently downloading books at the top.screen-20250205-170313.mp4
ZimManageViewModelTestaccording to this new change.DownloadTestwhich was failing after making this change.