Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4159 migrate help fragment to compose #4217

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SOUMEN-PAL
Copy link

Fixes #4159

📌 Summary

Migrated HelpFragment from XML-based UI to Jetpack Compose.

🔄 Changes Made

  1. Created new Composable components

    • Added HomeScreen.kt and HomeScreenItem.kt to handle the UI logic in Jetpack Compose.
  2. Updated HelpFragment.kt

    • Converted HelpFragment to return a Composable UI instead of using View Binding.
  3. Updated dependencies

    • Added necessary Jetpack Compose dependencies and versions in Libs.kt and Versions.kt in buildSrc.
  4. Handled Navigation

    • Introduced a variable for navigation, which is overridden in KiwixHelpFragment.kt, as the host fragment ID is required for Composable-to-Fragment and vice versa navigation.

🖼️ Screenshots / GIFs

@SOUMEN-PAL
Copy link
Author

@MohitMaliFtechiz sir I would like to put a thing in notice that whenever i sync the gradel using sync now after sync some string.xml files are automatically changed or updated. I am not able to know why.
Screenshot from 2025-02-07 20-47-40

The above image shows before sync and after sync status of the files.

@MohitMaliFtechiz
Copy link
Collaborator

@SOUMEN-PAL This is due to our gradle task, which we have added to fix #3176. Please do not include this automate change in commit.

task("renameTarakFile") {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate HelpFragment to jetpack.
2 participants