Fix library scroll issue - part 1 #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BPerlakiH
commented
Feb 16, 2025
| } | ||
|
|
||
| @ViewBuilder | ||
| var articleActions: some View { |
There was a problem hiding this comment.
this became: ArticleActions
BPerlakiH
commented
Feb 16, 2025
| } | ||
|
|
||
| @ViewBuilder | ||
| var supplementaryActions: some View { |
There was a problem hiding this comment.
this became: CopyPasteMenu
BPerlakiH
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1117 +/- ##
==========================================
- Coverage 35.07% 34.81% -0.27%
==========================================
Files 135 137 +2
Lines 7808 7868 +60
==========================================
Hits 2739 2739
- Misses 5069 5129 +60 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly fixing the issue: #1116
There were 2 main issues:
ViewModifierwithin aForEachloop. It was hard to track down, but the possible explanation for this, is that SwiftUI needs to see the view hierarchy tree in order to make performant diffs between states. Now it seems that the formerViewModifierwas erasing too heavily the type of the underlying views, and the performance got worse. Solution is to use view composition instead of view modifier.The good news is that it performs a lot better now.
There needs to be a part 2 fix for this as well. There's a "micro hang" on a freshly installed app, when scrolling the new section. This is mainly due to the icon loading and saving to the DB at the same time, for which I do have some solutions, but they are not final yet, so will leave them to a new PR.
Managed to add back the animations as well, and it works great:
news_with_animation.mov