CHNL-13255 Add wrapper view for hosting form webview #196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates a dialog we can wrap the webview we'll interact with around. I have a video showing the functionality below, but note this PR does not address the following open issues.
The main difference between this and the last feature add is that we can now click outside the view and it will close the dialog.
How do we communicate a button press closing the dialog? Our current bridge functionality looks for the view to be removed from the tree, which explains why the dialog closes after the webview has already been collapsed. We need a way of hooking into the button press action rather than the removal of the button id from the tree.I ended up using the close event we send as part of klaviyo.js. Much faster close times here!webview-as-dialog.webm
using the klaviyo.js "close" event:
Check List
^ we might have an issue supporting devices below Android API 17 but our SDK does not support those anyway.
Changelog / Code Overview
Test Plan
Related Issues/Tickets
CHNL-13255
CHNL-13258
CHNL-13259
CHNL-13256