-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(frontend): re-structure pages with old structure #91
Open
alcercu
wants to merge
1
commit into
fix(frontend)/apply-feedback-round-1
Choose a base branch
from
refactor(frontend)/directory-structure
base: fix(frontend)/apply-feedback-round-1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| import ImageDownload from "@/components/ImageDownload"; | ||
|
|
||
| import { IBadgesQuery } from "./queries"; | ||
|
|
||
| interface IBadges { | ||
| badgesData: IBadgesQuery["brandAssetsPageKlerosBadgesSection"]; | ||
| } | ||
|
|
||
| const Badges: React.FC<IBadges> = ({ badgesData }) => { | ||
| return ( | ||
| <div | ||
| className={ | ||
| "relative space-y-8 bg-background-1 px-6 py-12 lg:px-32 lg:py-24" | ||
| } | ||
| > | ||
| <h1 className="text-xl font-medium text-primary-text lg:text-2xl"> | ||
| {badgesData.header} | ||
| </h1> | ||
| <p className="pb-4 text-secondary-text lg:pb-8 lg:text-lg"> | ||
| {badgesData.subtitle} | ||
| </p> | ||
| <div className="flex flex-row flex-wrap justify-center gap-8 lg:gap-y-16"> | ||
| {badgesData.imageDownloads.map((imageDownload) => { | ||
| return ( | ||
| <ImageDownload key={imageDownload.image.url} {...imageDownload} /> | ||
| ); | ||
| })} | ||
| </div> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default Badges; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| import clsx from "clsx"; | ||
|
|
||
| import ColorCard from "./ColorCard"; | ||
| import { IColorsQuery } from "./queries"; | ||
|
|
||
| interface IColors { | ||
| colorsData: IColorsQuery["brandAssetsPageKlerosColorsSection"]; | ||
| } | ||
|
|
||
| const KlerosColorsSection: React.FC<IColors> = ({ colorsData }) => { | ||
| return ( | ||
| <div | ||
| className={ | ||
| "relative space-y-8 bg-background-2 px-6 py-12 lg:px-32 lg:py-24" | ||
| } | ||
| > | ||
| <h1 className="text-xl font-medium text-primary-text lg:text-2xl"> | ||
| {colorsData.header} | ||
| </h1> | ||
| <p | ||
| className={clsx( | ||
| "pb-4 text-sm font-medium text-secondary-text", | ||
| "lg:pb-8 lg:text-lg lg:font-normal", | ||
| )} | ||
| > | ||
| {colorsData.subtitle} | ||
| </p> | ||
| <div className="flex flex-row flex-wrap justify-center gap-8"> | ||
| {colorsData?.colorCards?.map((colorCard) => ( | ||
| <ColorCard | ||
| key={colorCard.name} | ||
| name={colorCard.name} | ||
| hexColor={colorCard.hexColor} | ||
| /> | ||
| ))} | ||
| </div> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default KlerosColorsSection; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| import clsx from "clsx"; | ||
|
|
||
| import CtaCard from "@/components/CtaCard"; | ||
|
|
||
| import { IFontsQuery } from "./queries"; | ||
|
|
||
| interface IFonts { | ||
| fontsData: IFontsQuery["brandAssetsPageKlerosFontsSection"]; | ||
| } | ||
|
|
||
| const Fonts: React.FC<IFonts> = ({ fontsData }) => { | ||
| return ( | ||
| <div | ||
| className={clsx( | ||
| "relative space-y-8 bg-background-1 px-6 pb-12", | ||
| "lg:space-y-16 lg:px-32 lg:pb-24 lg:pt-8", | ||
| )} | ||
| > | ||
| <h1 className="text-xl font-medium text-primary-text lg:text-2xl"> | ||
| {fontsData.header} | ||
| </h1> | ||
| <CtaCard | ||
| className="max-w-[583px] [&>p]:mb-14 [&>p]:text-base" | ||
| key={fontsData.linkCard.title} | ||
| title={fontsData.linkCard.title} | ||
| description={fontsData.linkCard.subtitle} | ||
| arrowLink={fontsData.linkCard.link} | ||
| /> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default Fonts; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| import clsx from "clsx"; | ||
|
|
||
| import ImageDownload from "@/components/ImageDownload"; | ||
|
|
||
| import { ILogosQuery } from "./queries"; | ||
|
|
||
| interface ILogos { | ||
| logosData: ILogosQuery["brandAssetsPageKlerosLogoSection"]; | ||
| } | ||
|
|
||
| const Logos: React.FC<ILogos> = ({ logosData }) => { | ||
| return ( | ||
| <div | ||
| className={clsx( | ||
| "relative space-y-12 bg-background-1 px-6 py-12", | ||
| "lg:space-y-16 lg:px-32 lg:py-24", | ||
| )} | ||
| > | ||
| <h1 className="text-xl font-medium text-primary-text lg:text-3xl"> | ||
| {logosData.header} | ||
| </h1> | ||
| <div | ||
| className={ | ||
| "flex flex-row flex-wrap justify-center gap-x-8 gap-y-12 lg:gap-y-16" | ||
| } | ||
| > | ||
| {logosData.imageDownloads.map((imageDownload) => { | ||
| return <ImageDownload key={imageDownload.name} {...imageDownload} />; | ||
| })} | ||
| </div> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default Logos; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 10 additions & 6 deletions
16
...nents/BrandAssets/LogosPackageSection.tsx → ...-assets/components/LogosPackage/index.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Avoid using title as a key and consider more robust styling.
Using the title as a React key can lead to issues if titles change or if you have multiple cards with the same title. Additionally, direct child selectors in styling make the component more brittle to changes in the CtaCard's internal structure.
For the key issue:
And consider adding a more robust approach to styling by using a specific class name instead of direct child selectors, which would require changes to the CtaCard component as well.
📝 Committable suggestion