Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omnibus: Recent Changes #261

Open
3 tasks
klikli-dev opened this issue Oct 31, 2024 · 1 comment
Open
3 tasks

Omnibus: Recent Changes #261

klikli-dev opened this issue Oct 31, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@klikli-dev
Copy link
Owner

klikli-dev commented Oct 31, 2024

@klikli-dev klikli-dev added the bug Something isn't working label Oct 31, 2024
@Eqis-Edu
Copy link

Eqis-Edu commented Oct 31, 2024

Fix remaining language adjustments from MuteTiefling's review in 1237

About the ritual dummies capitalization I commit now. Check #1261
About ritual messages ALL (conditions, started, completed and stopped) are in lowercase letters, in ENUSProvider from line 682 to 1097, I don't think it's necessary to change this now.

Fix 260 and/or choose better blocks for the pentacle using those blocks

Solved the render in 1.108.2.
Regarding changing blocks, I don't see any problems as long as there are reasons for choosing them. They may seem random and without much sense, but I thought about the motivation for each block when making the choices.

divination rod config page review: 1237

I think the quote in the comment is wrong, it seems to be talking about the point above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants