Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random Animals, Smelter Spirit, Familiars checkup, Achievements Optimizer compatibility and other things #1246

Merged
merged 41 commits into from
Nov 19, 2024

Conversation

Eqis-Edu
Copy link
Contributor

@Eqis-Edu Eqis-Edu commented Oct 31, 2024

Specialized Possessing Random Animals

Foliot tier

Type Recipe (activation item: foliot bound book) Animals
Common 4x seeds, 4x crops, use egg chicken, cow, pig, sheep, squid, wolf
Water 2x mud, 2x clay block, 2x kelp, 2x sea grass, use snowball axolotl, frog, dolphin, cod, salmon, tropical fish, pufferfish, squid, glow squid, tadpole, turtle, snow golem
Small 2x strings, 2x sugar, 2x iron nugget, 2x feather, use egg allay, bat, bee, parrot, cat, ocelot, fox, rabbit

Djinni tier

Type Recipe (activation item: djinni bound book) Animals
Rideable 2x wheat block, apple, golden apple, carrot, golden carrot, cactus, warped fungus, use xp bottle pig, camel, donkey, horse, skeleton horse, zombie horse, llama, trader llama, mule, strider
Villager bed, campfire, pie, use xp bottle villager or Wandering Trader
Special 2x wool, any mushroom block, moss block, iron block, packed ice, bambo block, terracota, use firework armadillo, mooshroom, panda, polar bear, goat, iron golem, sniffer

Wild Tier
All above, but in group (7 if originally foliot, 3 if originally djinni)
Same craft but activation item is spirit gem instead bound book

  • As with the repair rituals, they all foliot and djinni are in just one dictionary entry, wild is in one other entry
  • All rituals have respective advancement
  • Fun fact "common" are the animals that exists in the minecraft beta version

Smelter Spirit Job

Makes all furnace recipes, without fuel be gone pollution

Tier Speed Recipe (activation item: respective bound book)
Foliot 1x Coal, furnace, campfire
Djinni 2x Fire charge, blast furnace, smoker, flint and steel
Afrit 10x Blaze rod, lava bucket, magma block, red nether brick, soul campfire
Marid 100x Dragon breath, iesnium block, crying obsidian, coal block, gold block, spirit campfire
  • The speed is compared to the furnace, and yeah, this scales a lot
  • All rituals have respective advancement
  • Respective Dictionary entry for each tier

Achievements Optimizer compatibility

I finally found a solution for advancements that works 100%.
Although the latest update made it compatible and released without many problems, needing a bit of luck to update at the right time or something like that (changing the inventory a few times for it to work).
The "Achievements Optimizer" mod changes a bit of the item check in the inventory and this was blocking players.
Now you need to use the chalk once to "learn" about it, as this method (item use) has no changes and it worked every time.

Familiars checkup

  • Add flying passive tag to bat familiar
  • Add goats tag to goat familiar
  • Fix blacksmith dummy text "Nlacksmith"
  • Fix format error in a headless ratman entry page
  • Add text about other deer effects
  • Removed particle effect from deer and beaver (like others familiar)
  • Increase default chance of blacksmith repair to 0.33 (from 0.05)
  • Slight change in deer step assist, only 1 extra block, 2 when upgraded by blacksmith
  • Configurable greedy block search range and increase default value to 32 horizontal and 16 vertical (from 10 and 5)
  • Familiar still sitting when owner change dimension (bug reported in discord)
  • Add FamiliarPanicGoal for familiar to stand up when panicking

Other things

  • Translations, check #261;
  • Gem crushing ignore multiplier;
  • Crushing ae2 certuz quartz and fluix;
  • Mining actually additions black quartz;
  • Possessed Witches drop Uncraftable Potions #1239
  • Revert Empty Magic Lamp Change #1249
  • Information about Pentacles in the Book are inconsistent / missleading #1250
  • Add Foil to "natural" items, see the comment in sapling trader  #1251
  • Item natural (stripped) log use covered texture (like others natural item)
  • Black chalk advancement #1252
  • Easier cursed honey (sacrifice any passive flying, not only bat)
  • Easier gray paste (use phantom membrane instead wind charge)
  • Fix Dimensional Mineshaft Entry not showing config text
  • Some possessions entities receives related tags
  • Moved possess warden to afrit (is a powerful enemy)
  • Start changing ritual dummies to "public"
  • More tips about divination rod troubleshooting
  • Ritual type "summon_wild" can use tags (like the normal "summon")
  • Auto gen ritual hidden advancements
  • Silverfish horde spawn 5 (like others hordes, instead of 7)
  • Stop ritual satchel foil if an item inside as less than 40% of durability
  • Miners show weight in EMI (parity with JEI)
  • Fixed ritual satchel t2 wrong placing flying blocks

Changed Groves generation to solve #1022

  • Add a stone crust
  • Moved to y 9 ~ 48 (from 25 ~ 60)
  • Returned to any overworld biome
  • Only one sphere, but bigger
  • 25% more frequent

@MuteTiefling
Copy link
Contributor

Excellent changes with gem crushing, thanks. Was about to raise that since it causes dupe loops with other mods.

@Eqis-Edu Eqis-Edu mentioned this pull request Nov 5, 2024
@RIExJonny
Copy link

so quick question on this as idk if i am reading it right but i am on the right mod pack .16 for atm but it still will not unlock the pentacles for black chalk

@Eqis-Edu
Copy link
Contributor Author

Eqis-Edu commented Nov 5, 2024

so quick question on this as idk if i am reading it right but i am on the right mod pack .16 for atm but it still will not unlock the pentacles for black chalk

This post is not yet implemented (is a pull request), so the changes here are not officially in the mod.

@Eqis-Edu Eqis-Edu changed the title Achievements Optimizer compatibility Specialized Possessing Random Animals and Achievements Optimizer compatibility Nov 10, 2024
"entity_tag_to_summon": "occultism:random_animals_special",
"ingredients": [
{
"item": "minecraft:white_wool"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These recipes that require a bunch of different yet similar items are no fun as a player and really don't add anything to the experience (Budding Amethyst recipes also suffers from this, making the player sit and stare at a budding amethyst for an hour to get all the different growth stages.). Using the wool tag here would make more sense.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will change this recipe a little, thanks for the feedback

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed the specific wools to 2 any wool and the mushrooms blocks to 2 any mushrooms (not full block)

"item": "minecraft:black_wool"
},
{
"item": "minecraft:brown_mushroom_block"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, what does forcing the block here add over simply having them supply a mushroom?

"tag": "c:storage_blocks/bone_meal"
},
{
"item": "minecraft:soul_sand"
Copy link
Contributor

@MuteTiefling MuteTiefling Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these don't feel very fitting to a villager summon, like soul sand and quartz. I'd suggest some simpler ingredients like some tools and seeds. A hoe, axe, and 4 seeds would be very suitable. Maybe toss in a compost bin in there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In occultism villagers there is a tag "human" this recipe is a reference to the chemical compounds of the human body (soulsand is because villagers probably have souls), maybe i'll refine this

Copy link
Contributor

@MuteTiefling MuteTiefling Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remember that a recipe like this is a Quality of Life recipe. In most cases, going out and grabbing a villager in a Soul Gem will be the easiest option. But if there are no villages nearby, you'll want to turn to a recipe like this. It shouldn't be so daunting.

Keep it simple. The player is already punished enough by the fact they can't find a village.

Other summoning recipes are generally quite simple compared to this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to a bed, campfire and pie to kindly invite the villager into your home

@@ -37,7 +37,7 @@
},
"ritual_dummy": {
"count": 1,
"id": "occultism:ritual_dummy/craft_miner_ancient_eldritch"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be mindful of renaming ids... this breaks things in packs where quests and other things may be relying on them. There's no need to be doing this in release, it should be saved for major version changes instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the id defines the automatic generation of the icon, which indicates the pentacle, in this case it was necessary to change to correct it because it was visually misleading the players

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair. I've just had to make changes to quests after every one of these updates of yours and they haven't always been due to that sort of necessity.

Just asking that you be mindful.

@Eqis-Edu Eqis-Edu changed the title Specialized Possessing Random Animals and Achievements Optimizer compatibility Random Animals, Smelter Spirit, Familiars checkup, Achievements Optimizer compatibility and other things Nov 13, 2024
@Eqis-Edu
Copy link
Contributor Author

@klikli-dev I believe I have checked everything and this PR is ready (I should use the new book datagen format more, one day I will transfer everything, but it will still take a few weeks at least)

@klikli-dev klikli-dev merged commit e5819c2 into klikli-dev:version/1.21.1 Nov 19, 2024
@klikli-dev
Copy link
Owner

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants