-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Random Animals, Smelter Spirit, Familiars checkup, Achievements Optimizer compatibility and other things #1246
Conversation
Excellent changes with gem crushing, thanks. Was about to raise that since it causes dupe loops with other mods. |
so quick question on this as idk if i am reading it right but i am on the right mod pack .16 for atm but it still will not unlock the pentacles for black chalk |
This post is not yet implemented (is a pull request), so the changes here are not officially in the mod. |
"entity_tag_to_summon": "occultism:random_animals_special", | ||
"ingredients": [ | ||
{ | ||
"item": "minecraft:white_wool" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These recipes that require a bunch of different yet similar items are no fun as a player and really don't add anything to the experience (Budding Amethyst recipes also suffers from this, making the player sit and stare at a budding amethyst for an hour to get all the different growth stages.). Using the wool tag here would make more sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will change this recipe a little, thanks for the feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed the specific wools to 2 any wool and the mushrooms blocks to 2 any mushrooms (not full block)
"item": "minecraft:black_wool" | ||
}, | ||
{ | ||
"item": "minecraft:brown_mushroom_block" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly, what does forcing the block here add over simply having them supply a mushroom?
"tag": "c:storage_blocks/bone_meal" | ||
}, | ||
{ | ||
"item": "minecraft:soul_sand" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these don't feel very fitting to a villager summon, like soul sand and quartz. I'd suggest some simpler ingredients like some tools and seeds. A hoe, axe, and 4 seeds would be very suitable. Maybe toss in a compost bin in there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In occultism villagers there is a tag "human" this recipe is a reference to the chemical compounds of the human body (soulsand is because villagers probably have souls), maybe i'll refine this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just remember that a recipe like this is a Quality of Life recipe. In most cases, going out and grabbing a villager in a Soul Gem will be the easiest option. But if there are no villages nearby, you'll want to turn to a recipe like this. It shouldn't be so daunting.
Keep it simple. The player is already punished enough by the fact they can't find a village.
Other summoning recipes are generally quite simple compared to this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to a bed, campfire and pie to kindly invite the villager into your home
@@ -37,7 +37,7 @@ | |||
}, | |||
"ritual_dummy": { | |||
"count": 1, | |||
"id": "occultism:ritual_dummy/craft_miner_ancient_eldritch" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please be mindful of renaming ids... this breaks things in packs where quests and other things may be relying on them. There's no need to be doing this in release, it should be saved for major version changes instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the id defines the automatic generation of the icon, which indicates the pentacle, in this case it was necessary to change to correct it because it was visually misleading the players
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair. I've just had to make changes to quests after every one of these updates of yours and they haven't always been due to that sort of necessity.
Just asking that you be mindful.
@klikli-dev I believe I have checked everything and this PR is ready (I should use the new book datagen format more, one day I will transfer everything, but it will still take a few weeks at least) |
Thanks a lot! |
Specialized Possessing Random Animals
Foliot tier
Djinni tier
Wild Tier
All above, but in group (7 if originally foliot, 3 if originally djinni)
Same craft but activation item is spirit gem instead bound book
Smelter Spirit Job
Makes all furnace recipes, without fuel
be gone pollutionAchievements Optimizer compatibility
I finally found a solution for advancements that works 100%.
Although the latest update made it compatible and released without many problems, needing a bit of luck to update at the right time or something like that (changing the inventory a few times for it to work).
The "Achievements Optimizer" mod changes a bit of the item check in the inventory and this was blocking players.
Now you need to use the chalk once to "learn" about it, as this method (item use) has no changes and it worked every time.
Familiars checkup
Other things
Changed Groves generation to solve #1022